Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48240][DOCS] Replace Local[..] with "Local[...]" in the docs #46535

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented May 11, 2024

What changes were proposed in this pull request?

The pr aims to replace Local[..] with "Local[...]" in the docs

Why are the changes needed?

1.When I recently switched from bash to zsh and executed command ./bin/spark-shell --master local[8] on local, the following error will be printed:
image

2.Some descriptions in the existing documents have been written as --master "local[n]", eg:

./bin/pyspark --master "local[2]"

3.The root cause is: https://blog.peiyingchi.com/2017/03/20/spark-zsh-no-matches-found-local/
image

Does this PR introduce any user-facing change?

Yes, with the zsh becoming the mainstream of shell, avoid the confusion of spark users when submitting apps with ./bin/spark-shell --master "local[n]" ... or ./bin/spark-sql --master "local[n]" ..., etc

How was this patch tested?

Manually test
Whether the user uses bash or zsh, the above --master "local[n]" can be executed successfully in the expected way.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label May 11, 2024
@panbingkun
Copy link
Contributor Author

@panbingkun panbingkun marked this pull request as ready for review May 11, 2024 07:39
@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants