[SPARK-48027][SQL][FOLLOWUP] Add comments for the other code branch #46536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @AngersZhuuuu cc @cloud-fan |
cloud-fan
reviewed
May 13, 2024
| // right outer join output: (3, 3), (null, 4) | ||
| // right key output: 3, 4 | ||
| // Any join side always produce a superset output of its corresponding | ||
| // join keys, but for transitive join keys we need to check the join type. |
There was a problem hiding this comment.
shall we refine and move the comments to the beginning? Then we don't need to duplicate it
cloud-fan
approved these changes
May 14, 2024
|
thanks, merging to master! |
|
@cloud-fan Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR propose to add comments for the other code branch.
Why are the changes needed?
#46263 missing the comments for the other code branch.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
'No'.