[STORM-3380] Use Objects.equals to avoid possible NullPointerException #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bd2019us Thanks, looks great. Could you squash to one commit, and we can merge after the 24-hour waiting period? |
HeartSaVioR
reviewed
Apr 30, 2019
| @@ -2004,7 +2005,7 @@ private static ComponentPageInfo thriftifyCompPageData( | |||
| win2stats.put(FAILED, ClientStatsUtil.getMapByKey(data, WIN_TO_FAILED)); | |||
|
|
|||
| String compType = (String) data.get(TYPE); | |||
| if (compType.equals(ClientStatsUtil.SPOUT)) { | |||
| if (Objects.equals(compType,ClientStatsUtil.SPOUT)) { | |||
There was a problem hiding this comment.
It looks like only avoiding NPE, which also makes misleading as component being interpreted as bolt. We should see what are the actual cases of data.get(TYPE) being null, and decide how to fix based on the case.
There was a problem hiding this comment.
I agree. Maybe also consider throwing exceptions if it will ever be null. Need to understand it more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found that if the Map "data" does not have the key "TYPE", the String "compType" may cause potential risk of NullPointerException since it is immediately used after initialization and there is no null checker. One recommended API is Objects.equals(String,String) which can avoid this exception.