STORM-3544 Ability to find topologies with low worker uptime on UI #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishorvpatil
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
👍 The change looks good as reviewed in prior PR. Thank you @dandsager1 for the patch. @agresch Thank you for resolving the merge conflicts.
|
Can we modify TopologySummary instead of adding a new structure? |
|
I think the reason was there was concern about the REST API fetching data about all the workers for all the topologies to get the min uptime. By having a separate page, this only gets hit when specifically looking for this information. Most of the time most users would not care. If that is not a concern, I would agree moving it to Topology summary makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @dandsager1 's work to create a new page to see all topologies with the min worker uptime on one page. I've updated the generated thrift.
We've had issues where nodes are bad or there were bugs were some topologies could not launch workers. This page allows one place to quickly find topologies that may be having issues with nodes, rather than having to go to each topology page individually.