Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5976] Support Flink 1.18 #4739

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keinkonzept
Copy link

What is this PR for?

This PR aims to support Flink 1.18

What type of PR is it?

Feature

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5976

How should this be tested?

Pass GA.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

@Reamer Reamer requested a review from zjffdu March 25, 2024 08:51
@pan3793
Copy link
Member

pan3793 commented Mar 25, 2024

java.lang.RuntimeException: error reading Scala signature of org.apache.flink.table.api.ImplicitExpressionConversions: unsafe symbol x$2 (child of value <local api>) in runtime reflection universe
  at scala.reflect.internal.pickling.UnPickler.unpickle(UnPickler.scala:44)
  at scala.reflect.runtime.JavaMirrors$JavaMirror.unpickleClass(JavaMirrors.scala:622)

Same error I faced in my previous try, but no idea after some digging ...

@zjffdu
Copy link
Contributor

zjffdu commented Mar 26, 2024

Details

Most likely it is due to scala version

.classLoader(Thread.currentThread().getContextClassLoader())
.config((ReadableConfig) config)
.catalogStoreHolder(
CatalogStoreHolder.newBuilder()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, thank you for the PR. I was able to compile your branch and it booted up and worked as expected, but the catalog registration did not work in the sense of adding a file catalog store. Looking in the Flink repo, it looks like they started instantiating the catalog manager differently. I don't know if the current flink shim structure is easily adapted to the new utilities added or something else needs to be done. If I get time this weekend I'd like to build off your work to see if we can get it working.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking a look at it. I stumbled upon the same - was a bit too quick to celebrate after getting it up and running initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants