Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-6018] Update gRPC version from 1.51.0 to 1.55.1 for successful Apache Zeppelin build on s390x architecture #4758

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aditi-sharma-1
Copy link

@aditi-sharma-1 aditi-sharma-1 commented Apr 18, 2024

This update modifies the grpc-java dependency version from 1.51.0 to 1.55.1. This change ensures compatibility and resolves build issues encountered on the s390x architecture. After implementing this change, the Apache Zeppelin package now builds successfully on the s390x architecture.

Attaching the log file and screenshots while building Apache Zeppelin on s390x:

build-on-s390x-logs.txt

build-screenshot-1 build-screenshot-2

…n s390x architecture

In the s390x architecture, the Apache Zeppelin package builds successfully when the grpc dependency version in the pom.xml file is changed from version 1.51.0 to version 1.62.2. Therefore, I have updated the grpc version in the pom.xml file.
@Reamer
Copy link
Contributor

Reamer commented Apr 19, 2024

Can you please create a JIRA ticket and update the license file.
You can find a complete commit at 09bd938.

@aditi-sharma-1
Copy link
Author

Sure, I'll create the Jira ticket for this issue and update the license file. Thank you, Reamer.

@jongyoul
Copy link
Member

By the way, could you please check the CI as well?

aditi-sharma-1 and others added 2 commits April 29, 2024 14:51
Updated the grpc version in LICENSE from 1.51.0 to 1.62.2
@aditi-sharma-1
Copy link
Author

Sure @jongyoul, I will check the CI.

I have also updated the license file and created the Jira ticket - 6018
Thank you.

@pan3793
Copy link
Member

pan3793 commented Apr 29, 2024

Hmm... IIRC, there is a enforced rule to ensure that gRPC protobuf version aligned

@jongyoul jongyoul changed the title Update grpc version in pom.xml for successful Apache Zeppelin build on s390x architecture [ZEPPELIN-6018] Update grpc version in pom.xml for successful Apache Zeppelin build on s390x architecture Apr 30, 2024
@aditi-sharma-1
Copy link
Author

@pan3793 Could you please elaborate ?

@pan3793
Copy link
Member

pan3793 commented May 6, 2024

@aditi-sharma-1 ignore my previous comments, please follow the error reported by CI to fix it.

@aditi-sharma-1
Copy link
Author

Sure @pan3793 ,

I have downgraded the gRPC version from 1.62.2 to 1.55.1. Could you please rerun it once? Thank you.

@pan3793
Copy link
Member

pan3793 commented May 13, 2024

Sure @pan3793 ,

I have downgraded the gRPC version from 1.62.2 to 1.55.1. Could you please rerun it once? Thank you.

Sorry, I'm not a Zeppelin Committer thus I don't have power to rerun the CI. I saw another Committer triggered CI and the result looks good in this round.

@pan3793
Copy link
Member

pan3793 commented May 13, 2024

@aditi-sharma-1 please update your PR title to something like [ZEPPELIN-6018] Update gRPC from 1.51.0 to 1.55.1, and since the Zeppelin existing CI does not have s390x machines, please update the PR description to mention your local test result on s390x

@aditi-sharma-1
Copy link
Author

aditi-sharma-1 commented May 13, 2024

Sure, @pan3793 , I'll update the PR title and description
Thank you.

@aditi-sharma-1 aditi-sharma-1 changed the title [ZEPPELIN-6018] Update grpc version in pom.xml for successful Apache Zeppelin build on s390x architecture [ZEPPELIN-6018] Update gRPC version from 1.51.0 to 1.55.1 for successful Apache Zeppelin build on s390x architecture May 13, 2024
@pan3793
Copy link
Member

pan3793 commented May 14, 2024

CI failure should be irrelative, cc @jongyoul @huage1994 who has write permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants