Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task run, actor call, deprecate top level call #558

Merged
merged 15 commits into from
Jun 10, 2024
Merged

Conversation

vladfrangu
Copy link
Member

Closes #117
Also starts covering the slightest part of #554

Still needs tests!

@vladfrangu vladfrangu requested review from B4nan and barjin April 29, 2024 16:47
@vladfrangu vladfrangu self-assigned this Apr 29, 2024
@github-actions github-actions bot added this to the 88th sprint - Tooling team milestone Apr 29, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 29, 2024
@vladfrangu vladfrangu marked this pull request as ready for review May 15, 2024 12:17
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label May 15, 2024
@B4nan
Copy link
Member

B4nan commented May 15, 2024

I believe we want to keep the command reshuffling to v1 (that's what the PR is doing, right?)

@vladfrangu
Copy link
Member Author

I believe we want to keep the command reshuffling to v1 (that's what the PR is doing, right?)

apify call is remaining as a command, but it's printing a warning that it's deprecated and people should start using actor call. I can revert that part if we really want to, but I don't think its needed

@B4nan
Copy link
Member

B4nan commented May 15, 2024

please do, i would rather keep this for v1 where we will do similar changes on other places too (basically the whole #554). let's keep the implementation (running tasks locally), i would only revert the location (so keep apify call as the main documented and suggested API now)

src/commands/call.ts Outdated Show resolved Hide resolved
@vladfrangu vladfrangu requested a review from B4nan May 16, 2024 09:29
@vladfrangu vladfrangu merged commit 3e21cbd into master Jun 10, 2024
21 checks passed
@vladfrangu vladfrangu deleted the vlad/task-run branch June 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to run actor task localy
2 participants