Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment with restoring moka to see how performance varies #5204

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

garypen
Copy link
Contributor

@garypen garypen commented May 20, 2024

First replace the storage cache and see how things look. Then think about the other places where we use LruCache.

First replace the storage cache and see how things look. Then think
about the other places where we use LruCache.
@garypen garypen self-assigned this May 20, 2024
Copy link
Contributor

@garypen, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

We have tests which expect exact numbers, so we need to make moka less
lazy about updating it's entry use tracking.

This might be something we can relax later, but I'll just make it strict
everywhere for now.
@garypen garypen marked this pull request as ready for review May 21, 2024 07:34
@garypen garypen marked this pull request as draft May 21, 2024 07:36
@BrynCooke BrynCooke closed this May 22, 2024
@BrynCooke BrynCooke reopened this May 22, 2024
@router-perf
Copy link

router-perf bot commented May 22, 2024

CI performance tests

  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • const - Basic stress test that runs with a constant number of users
  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning

@Geal
Copy link
Contributor

Geal commented May 24, 2024

@garypen any insights from running this? Do you see different behaviour when running the same query often, or a lot of different queries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants