Update amending example #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzensp
requested changes
May 14, 2024
docs/modules/language-tutorial/pages/02_filling_out_a_template.adoc
Outdated
Show resolved
Hide resolved
| @@ -103,35 +106,44 @@ dodo = (stockPigeon) { // <2> | |||
| <3> New fields can be added to objects when amending. | |||
|
|
|||
| Notice how you only have to change `taxonomy.species`. | |||
| In this example, `bird.taxonomy` has `kingdom`, `clade`, `order` and `species`. | |||
| In this example, `stockPigeon.taxonomy` has `kingdom`, `clade`, `order` and `species`. | |||
| You are amending `stockPigeon`, to define `woodPigeon`. | |||
Co-authored-by: Philip K.F. Hölzenspies <holzensp@gmail.com>
holzensp
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through the Ammending section of the "Filling out a template" tutorial, it seemed like the code snippets and the textual explanation didn't align nicely. I've updated the code snippets to match the text surrounding them as it seemed like the text was the correct one. Here's a summary of changes:
kingdom,clade, andordertostockPigeon.taxonomyas the text was referencing those fields, but those were missing from the code snippet.