Fix unhelpful -help message #7224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewHoos
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
I feel like we should be able to handle this on ArgumentParser level, thus requesting relevant reviewers |
grynspan
reviewed
Jan 3, 2024
| @@ -99,15 +99,14 @@ extension SwiftPackageTool { | |||
|
|
|||
| func run(_ swiftTool: SwiftTool) throws { | |||
| // See if have a possible plugin command. | |||
| guard let command = remaining.first else { | |||
| guard let command = remaining.first, | |||
| !Set(["", "-h", "--help", "-help"]).contains(command) else { | |||
There was a problem hiding this comment.
There's no point in making this a Set. The performance is going to be at least O(n) in order to simply construct the set, and it's a temporary value. It can just be an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7218
Fix the unhelpful dialogue when invoking
swift package -helpMotivation:
swift package -helpis documented as a valid spelling. So it should workModifications:
Specifically detect
-helpin the argumentResult:
swift package -helpprints the help message