[6.0][Package/ModuleGraph] Allow cyclic package dependencies if they don't introduce a cycle in a build graph #7541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apple/sourcekit-lsp#1248 |
bnbarham
approved these changes
May 8, 2024
MaxDesiatov
approved these changes
May 9, 2024
… introduce a cycle in a build graph (apple#7530) It should be possible for packages to depend on each other if such dependence doesn't introduce cycles in the build graph. - Introduced a new DFS method to walk over graphs that breaks cycles. - Replaces use of `findCycle` + `topologicalSort` with `DFS` while building manifest and package graphs. This allows cycles in dependencies to be modeled correctly. - Removes some of the redundant data transformations from modules graph. - Modifies `ResolvedPackage` to carry identities of its dependencies instead of resolved dependencies themselves. This helps to simplify logic in `createResolvedPackages`. - Adds detection of target cycles across packages. Makes it possible for package A to depend on package B and B to depend on A if their targets don't form a cycle. (cherry picked from commit 8b12909)
xedin
force-pushed
the
allow-dependency-cycles-6.0
branch
from
6246c3a
to
550650b
Compare
|
apple/sourcekit-lsp#1248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
It should be possible for packages to depend on each other if such
dependence doesn't introduce cycles in the build graph.
findCycle+topologicalSortwithDFSwhilebuilding manifest and package graphs. This allows cycles in dependencies
to be modeled correctly.
ResolvedPackageto carry identities of its dependenciesinstead of resolved dependencies themselves. This helps to simplify
logic in
createResolvedPackages.Makes it possible for package A to depend on package B and B to depend
on A if their targets don't form a cycle.
Scope: Package graph
Main Branch PRs: [Package/ModuleGraph] Allow cyclic package dependencies if they don't introduce a cycle in a build graph #7530
Risk: Low
Reviewed By: @MaxDesiatov
Testing: Added new test-cases to the test suite