-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sendable to FileRuleDescription #7563
Conversation
oops, the same changes are included in #7559 |
We haven't added sendable annotations on most of SwiftPM right now. Happy to have them added piecemeal, but could you add to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM, but needs to be submitted on main
first.
Just noticed this was filed against release/6.0
. It has to land in main
first.
I changed the base to main |
@swift-ci test |
@swift-ci test windows |
Motivation:
I found that the
FileRuleDescription
doesn't conform toSendable
; due to this, some products fail to build for Swift 6.Modifications:
Some structs conform to
Sendable
Result:
I passed to build on the latest Swift 6.0 snapshot.