Fix functions not being kept for debugger #73678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
approved these changes
May 16, 2024
slavapestov
reviewed
May 16, 2024
|
@swift-ci test windows |
At Onone, many types of functions (anything user written, compiler generated setters and getters, etc), should be kept in the final binary so they're accessible by the debugger. rdar://126763340 (cherry picked from commit 5298450)
SILFunction::shouldBePreservedForDebugger checks if some optimizations are enabled to decide whether a function should be preserved so its accessible form the debugger or not. Some of these settings used to live only in IRGenOptions making SILFunction depend on IRGenOptions. (cherry picked from commit 4aec4e7)
augusto2112
force-pushed
the
keep-for-deb-def-6
branch
from
9cacd27
to
c5ea0c3
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: At Onone, many types of functions (anything user written, compiler generated setters and getters, etc), should be kept in the final binary so they're accessible by the debugger. They were previously being optimized out.
Scope: changes which functions should be kept for the debugger or not.
Risk: Low, affects whether a function should be optimized out or not, but not the actual logic of IRGening functions.
Testing: Added a compiler test. Modified a few tests to match the current expected behavior.
Issue: rdar://126763340
Reviewer: @adrian-prantl @al45tair @eeckstein