Fix global accessor and class linker errors in package. #73686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
d26265f
to
e3cce07
Compare
|
@swift-ci smoke test |
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
1fefb0d
to
c379f0a
Compare
|
@swift-ci smoke test |
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
c379f0a
to
58cc800
Compare
|
@swift-ci smoke test |
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
58cc800
to
34d9594
Compare
|
@swift-ci smoke test |
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
97d5ef3
to
c80f6c5
Compare
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
9dfe9e3
to
f83861e
Compare
Add global accessors to symbol list if VarDecl is fragile, i.e. is non-resilient or its defining module allows non-resilient access. Don't set the class decl to hidden if it's in a package resilience domain; even though its defining module is built resilently, the class symbol should be visible across modules if they are in the same package with resilience-bypass optimization. In such case, treat its SubclassScope to Internal. Resolves rdar://127321129
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
f83861e
to
80855c8
Compare
|
@swift-ci smoke test |
elsh
changed the title
|
@swift-ci smoke test |
slavapestov
reviewed
May 21, 2024
elsh
force-pushed
the
elsh/ir-global-accessor
branch
from
d72f92b
to
36b4d2d
Compare
Add isStrictlyResilient() to nominal type and module decl.
|
@swift-ci smoke test |
nkcsgexi
reviewed
May 22, 2024
| @@ -5142,6 +5146,10 @@ bool NominalTypeDecl::isResilient() const { | |||
| return getModuleContext()->isResilient(); | |||
| } | |||
|
|
|||
| bool NominalTypeDecl::isStrictlyResilient() const { | |||
There was a problem hiding this comment.
Nitpick: strict is vague when used as an API name. A better alternative could be something like isNonResilientAccessDisallowed()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When package resilience optimization is enabled, global accessor symbols are not added to the SIL symbol list, causing a linker issue.
Resolves rdar://127321129&127308331