Add a check for serialized_for_package in MandatoryInlining #73715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch! Can we add some tests for it? |
|
@swift-ci smoke test |
will do, however this is a temporary fix; will have a proper fix that involves a lot more code change. |
|
Handled in the upcoming PR pending #73754. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the caller is [serialized] due to explicit
@inlinablebutthe callee was [serialized_for_package] due to package-cmo, the
callee is [serialized] and might contain loadable types, which
is normally disallowed. This check prevents such loadable types
from being inlined. This check is also added to PerformanceInlinerUtils.