[6.0] Respect @preconcurrency everywhere we diagnose Sendable issues
#73720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…currency` The diagnostic for non-Sendable globa/static `let` properties was checking for a Sendable conformance without considering `@preconcurrency`. Emit this diagnostic via a `@preconcurrency`-sensitive path. Fixes rdar://121889248. (cherry picked from commit 94a2529)
…f non-Sendable types (cherry picked from commit 290ec79)
(cherry picked from commit fc85f98)
…es in deinit Instance properties of non-sendable types cannot safely be accessed within deinitializers. Make sure we respect `@preconcurrency` when diagnosing these. (cherry picked from commit c326fd3)
When determining whether a non-sendable type is a nominal type that is affected by `@preconcurrency`, be sure to look at the specific type even when it's part of larger type, e.g., the `NS` in `NS?`. This makes `@preconcurrency` work properly through structural types like arrays, optionals, and dictionaries. While here, also check whether the nominal declaration itself has been marked as `@preconcurrency`. Fixes rdar://125081249. (cherry picked from commit d62b565)
(cherry picked from commit 0f8c478)
|
@swift-ci please test |
hborla
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: A number of places in the Swift type checker were providing diagnostics when a type is not
Sendablewithout respecting@preconcurrencyimports that would suppress or downgrade those diagnostics. This both impacts specific classes of diagnostics (such as the diagnostic when a global or staticlethas non-Sendabletype) and existing diagnostics where the non-Sendabletype is part of a larger non-Sendabletype, such asNonSendable?or[NonSendable].Original PR: #73676, #73698
Radar/issue: rdar://121889248, rdar://125081249
Risk: Low. The changes only affect diagnostics that are warnings prior to Swift 6, and only downgrades diagnostics from warnings -> suppressed (Swift < 6) or errors -> warnings (Swift >= 6).