[6.0][region-isolation] Create a non-"callee" kind of error for async let. #73724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am doing this separately from the previous fix for just normal region isolation since without transferring args and results enabled, we do not hit this code path. But since I am here, I want to fix it at the same time. rdar://127588005 (cherry picked from commit 787bb7d)
|
@swift-ci test |
hborla
approved these changes
May 17, 2024
|
@swift-ci test |
This cherry-picked commit is from before we wordsmithed a few diagnostics. This commit just updates the test to match the new diagnostic text.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This just changes callee -> DeclDescriptorKind DeclName in some of the diagnostics for async let like we did for other diagnostics.
Radars:
Original PRs:
Risk: Low. Just affects region isolation.
Testing: Updated tests/adding some tests to the test suite.
Reviewer: N/A