Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use spring-security native CSRF protection #33180

Closed
wants to merge 7 commits into from
Closed

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented May 5, 2024

  • Add the token to Login form.
  • Add the token to Signup form.
  • Get token added to login form, after a logout.

/ok-to-test tags="@tag.Sanity"

Caution

馃敶 馃敶 馃敶 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8965354124
Commit: 1510914
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Sanity/Datasources/ArangoDataSourceStub_spec.js
  2. cypress/e2e/Sanity/Datasources/Arango_Basic_Spec.ts
  3. cypress/e2e/Sanity/Datasources/AuthenticatedApiDatasource_spec.js
  4. cypress/e2e/Sanity/Datasources/AuthenticatedApiWithOAuth_spec.ts
  5. cypress/e2e/Sanity/Datasources/DSAutosaveImprovements_spec.ts
  6. cypress/e2e/Sanity/Datasources/DatasourceForm_spec.js
  7. cypress/e2e/Sanity/Datasources/ElasticSearchDatasource_spec.js
  8. cypress/e2e/Sanity/Datasources/GraphQL_spec.ts
  9. cypress/e2e/Sanity/Datasources/MongoDatasourceURI_spec.ts
  10. cypress/e2e/Sanity/Datasources/MySQLDataSourceStub_spec.js
  11. cypress/e2e/Sanity/Datasources/MySQLNoiseTest_spec.js
  12. cypress/e2e/Sanity/Datasources/MySQL_spec.js
  13. cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts
  14. cypress/e2e/Sanity/Datasources/PostgresDatasource_spec.js
  15. cypress/e2e/Sanity/Datasources/RedshiftDataSourceStub_spec.js
  16. cypress/e2e/Sanity/Datasources/RestApiDatasource_spec.js
  17. cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts
  18. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
  19. cypress/e2e/Sanity/Datasources/Styles_spec.js
To know the list of identified flaky tests - Refer here

@sharat87 sharat87 changed the title chore/csrf chore: Use spring-security native CSRF protection May 5, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 5, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot May 6, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot May 6, 2024
@sharat87 sharat87 added the ok-to-test Required label for CI label May 6, 2024
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label May 13, 2024
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant