Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allowing bottom tabs to be selectable as text #33263

Merged
merged 16 commits into from May 13, 2024
Merged

fix: allowing bottom tabs to be selectable as text #33263

merged 16 commits into from May 13, 2024

Conversation

AmanAgarwal041
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 commented May 8, 2024 •
edited by github-actions bot

Description

Enabling the bottom tabs overall for users to select the test for errors, response, logs etc. The tailwind css class select-none which was added to the whole of the application was getting applied to this area as well by inheriting the properties. Added select-text property which enables the user to select anything inside the container as text.

Fixes #32755
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9065702943
Commit: 9aeb5f4
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 8, 2024 •
edited

Walkthrough

The recent changes involve adding the select-text class to the className attributes of various components to enable text selection in different views like API response, JS response, debugger, and query debugger tabs. New test cases have been introduced to verify the presence and functionality of the select-text class. Additionally, a new tag has been included in the Cypress configuration for better test categorization.

Changes

File Path Change Summary
.../ApiResponseView.tsx, .../JSResponseView.tsx,
.../Debugger.tsx, .../QueryDebuggerTabs.tsx		 Added select-text class to className attributes in components for text selection.
.../cypress/tags.js Added @tag.Debugger for test categorization.
.../ApiResponseView.test.tsx, .../JSResponseView.test.tsx,
.../Debugger.test.tsx, .../QueryDebuggerTabs.test.tsx		 Introduced new test cases to validate the select-text class functionality.

Assessment against linked issues

Objective Addressed Explanation
[Bug]: error log is not copy-able (#32755) ✅ The addition of the select-text class enables text selection, allowing users to copy error logs, addressing the issue of error log not being copy-able.

The changes align with the requirements outlined in the linked issue by enhancing user experience through text selection capabilities, resolving the regression where copying error logs was not possible directly from the UI.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Core Query Execution Issues related to the execution of all queries Debugger Issues related to the debugger FE Coders Pod Issues related to users writing javascript in appsmith High This issue blocks a user from building or impacts a lot of users Integrations Pod Issues related to a specific integration Low effort Takes 1-2 days Needs Triaging Needs attention from maintainers to triage Production Regressed Scenarios that were working before but have now regressed labels May 8, 2024
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true recreate=true

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8997713589.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33263.
recreate: true.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Deploy-Preview-URL: https://ce-33263.dp.appsmith.com

@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8998822590.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33263.
recreate: .

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Deploy-Preview-URL: https://ce-33263.dp.appsmith.com

@AmanAgarwal041 AmanAgarwal041 added the ok-to-test Required label for CI label May 9, 2024
@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 9, 2024
@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 9, 2024
ayushpahwa
ayushpahwa reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@ayushpahwa ayushpahwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, can we explore if any tests can be added here?

@sneha122
Copy link
Contributor

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9028447050.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33263.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-33263.dp.appsmith.com

@sneha122
Copy link
Contributor

@AmanAgarwal041 Tested the changes, looks good, noticed one thing though, in error tabs the cursor does not change to selection one, it stays as default. Please check

Screen.Recording.2024-05-10.at.12.52.07.PM.mov

@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 10, 2024
@AmanAgarwal041
Copy link
Contributor Author

@AmanAgarwal041 Tested the changes, looks good, noticed one thing though, in error tabs the cursor does not change to selection one, it stays as default. Please check

Screen.Recording.2024-05-10.at.12.52.07.PM.mov

Multiple components collapsible, json viewer etc inside this have cursor: default so I think its better to leave this till the text is getting selected. @sneha122

@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 10, 2024
@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 11, 2024
@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 13, 2024
@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 13, 2024
@AmanAgarwal041 AmanAgarwal041 merged commit 71deecc into release May 13, 2024
44 checks passed
@AmanAgarwal041 AmanAgarwal041 deleted the fix/32755-copyable-bottom-tab branch May 13, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushpahwa ayushpahwa ayushpahwa left review comments

@hetunandu hetunandu hetunandu left review comments

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@sneha122 sneha122 sneha122 approved these changes

Assignees
No one assigned
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Core Query Execution Issues related to the execution of all queries Debugger Issues related to the debugger FE Coders Pod Issues related to users writing javascript in appsmith High This issue blocks a user from building or impacts a lot of users Integrations Pod Issues related to a specific integration Low effort Takes 1-2 days Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production Regressed Scenarios that were working before but have now regressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: error log is not copy-able
4 participants
@AmanAgarwal041 @sneha122 @ayushpahwa @hetunandu