New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove unnecessary flag ab_show_templates_instead_of_blank_canvas_enabled
#33313
chore: Remove unnecessary flag ab_show_templates_instead_of_blank_canvas_enabled
#33313
Conversation
…is turned to 100% now.
…ctors/buildingBlocksSelectors` and uses it to determine if any building blocks are being dragged. The purpose of this change is to improve the remove unncessary checks inside the Onboarding component.
…o chore-remove-GA-flag-ab_show_templates_instead_of_blank_canvas_enabled
WalkthroughWalkthroughThe recent updates primarily focus on refining feature flag usage and enhancing UI responsiveness related to drag-and-drop functionalities. Key changes include the removal of specific feature flags affecting canvas behavior, simplification of conditions for UI component display in the onboarding process, and a more integrated handling of widget and building block drag states. These alterations aim to streamline user experience and code maintainability. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ab_show_templates_instead_of_blank_canvas_enabled
…o chore-remove-GA-flag-ab_show_templates_instead_of_blank_canvas_enabled
Description
Additonally this pull request removes the unnecessary checks inside the Onboarding component by importing the
isDraggingBuildingBlockToCanvas
function fromselectors/buildingBlocksSelectors
and using it to determine if any building blocks are being dragged. --> IT is already being checked inDropTargetComponent.tsx
which renderst thisOnboarding
component.Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Templates, @tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9013874763
Commit: 7f53881
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?