chore: Permission group migrations #33332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivonk
changed the base branch from
pg
to
chore/create-tenant-anonymous-user-migration
Base automatically changed from
chore/create-tenant-anonymous-user-migration
to
pg
May 13, 2024 05:26
mohanarpit
reviewed
May 15, 2024
...rver/appsmith-server/src/main/java/com/appsmith/server/migrations/ce/R__finalMigrations.java
Outdated
Show resolved
Hide resolved
vivonk
changed the title
abhvsn
reviewed
May 20, 2024
...ver/appsmith-server/src/main/java/com/appsmith/server/migrations/MigrationHelperMethods.java
Show resolved
Hide resolved
...er/appsmith-server/src/main/java/com/appsmith/server/migrations/RepositoryHelperMethods.java
Show resolved
Hide resolved
app/server/appsmith-server/src/main/resources/sql/createIndexes.sql
Outdated
Show resolved
Hide resolved
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No
sharat87
approved these changes
May 21, 2024
| public class V11__cleanPermissionsInPermissionGroups extends AppsmithJavaMigration { | ||
| @Override | ||
| public void migrate(JdbcTemplate jdbcTemplate) throws Exception { | ||
| String sql = "UPDATE permission_group SET permissions = NULL"; |
There was a problem hiding this comment.
This clears the column for the whole table, no? Don't we need this column's data anymore? Can we remove it in today's release branch itself then? 🤔
There was a problem hiding this comment.
We don't reuqire this column anymore, it's deprecated. Removing it from release is a legit solution but that will require efforts and understanding of 1-2 places where this field is used + some initial migrations require this field so removing it is not a easy task.
This is a tech debt that we are carry forwarding from release to pg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?