Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use overflow: auto instead of scroll in widget explorer #33342

Merged
merged 1 commit into from May 14, 2024

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented May 10, 2024

image
This PR adds overflow: auto instead of overflow: scroll. because of overflow:scroll, there is a reserve space at bottom for scrollbar even when it is not required.

/ok-to-test tags="@tag.IDE"

Tip

馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9074032519
Commit: f7f68e7
Cypress dashboard url: Click here!

Copy link
Contributor

coderabbitai bot commented May 10, 2024

Walkthrough

Walkthrough

The recent updates aim to refine the user interface components in the application. This includes adjusting the scrolling behavior by updating the overflowX property in the AddWidgets component. Furthermore, a div element was substituted with a Flex component in the UIEntitySidebar, streamlining the layout and integrating more design system components for enhanced consistency and maintainability.

Changes

File Path Change Summary
.../EditorPane/UI/Add.tsx Changed overflowX from "scroll" to "auto" in AddWidgets component.
.../widgetSidebar/UIEntitySidebar.tsx Replaced a div with a Flex component, updated imports and element tags.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 004c3ca and f7f68e7.
Files selected for processing (2)
  • app/client/src/pages/Editor/IDE/EditorPane/UI/Add.tsx (1 hunks)
  • app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (2)
  • app/client/src/pages/Editor/IDE/EditorPane/UI/Add.tsx
  • app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 10, 2024
@jsartisan
Copy link
Contributor Author

/build-deploy-preview skip-tests=true env=release

@albinAppsmith
Copy link
Collaborator

/build-deploy-preview skip-test=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9027560069.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 33342.
recreate: .

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9027562253.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33342.
recreate: .

Copy link

Deploy-Preview-URL: https://appsmith-a4zromm6c-get-appsmith.vercel.app

馃毃 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will
likely behave unexpectedly. Consider using a full DP instead.
Learn more.

Copy link

Deploy-Preview-URL: https://ce-33342.dp.appsmith.com

@jsartisan jsartisan added the ok-to-test Required label for CI label May 13, 2024
@jsartisan jsartisan removed the ok-to-test Required label for CI label May 14, 2024
@jsartisan jsartisan force-pushed the fix/widget-explorer-cropping branch from 004c3ca to f7f68e7 Compare May 14, 2024 05:04
@jsartisan jsartisan added the ok-to-test Required label for CI label May 14, 2024
@jsartisan jsartisan merged commit b0f6950 into release May 14, 2024
41 checks passed
@jsartisan jsartisan deleted the fix/widget-explorer-cropping branch May 14, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants