Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONOT MERGE] - Testing External Contributor PR with CI checks #33349

Open
wants to merge 2 commits into
base: release
Choose a base branch
from
Open

[DONOT MERGE] - Testing External Contributor PR with CI checks #33349

wants to merge 2 commits into from
+61 −1

Conversation

riodeuno
Copy link
Contributor

@riodeuno riodeuno commented May 10, 2024 •
edited by github-actions bot

Testing CI for #32386
This shall be closed once CI checks pass.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9057998089
Commit: 48b8670
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/Apps/PromisesApp_spec.js
  2. cypress/e2e/Regression/ClientSide/ActionExecution/ActionSelector_JsToNonJSMode_1_spec.ts
  3. cypress/e2e/Regression/ClientSide/ActionExecution/ClearStore_spec.ts
  4. cypress/e2e/Regression/ClientSide/ActionExecution/RemoveValue_spec.ts
  5. cypress/e2e/Regression/ClientSide/ActionExecution/StoreValue_spec.ts
  6. cypress/e2e/Regression/ClientSide/Autocomplete/Autocomplete_setters_spec.ts
  7. cypress/e2e/Regression/ClientSide/Autocomplete/Bugs_AC_Spec.ts
  8. cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC1_spec.ts
  9. cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC2_spec.ts
  10. cypress/e2e/Regression/ClientSide/Autocomplete/PropertyPaneSuggestion_spec.ts
  11. cypress/e2e/Regression/ClientSide/Binding/JSObjectToInput_Spec.ts
  12. cypress/e2e/Regression/ClientSide/Binding/JSObjectToListWidget_Spec.ts
  13. cypress/e2e/Regression/ClientSide/Binding/JSObject_Postgress_Table_spec.js
  14. cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts
  15. cypress/e2e/Regression/ClientSide/Binding/Promises_2_Spec.ts
  16. cypress/e2e/Regression/ClientSide/BugTests/Bug20275_Spec.js
  17. cypress/e2e/Regression/ClientSide/BugTests/Bug29566_Spec.ts
  18. cypress/e2e/Regression/ClientSide/BugTests/CatchBlock_Spec.ts
  19. cypress/e2e/Regression/ClientSide/BugTests/DS_Bug28985_spec.ts
  20. cypress/e2e/Regression/ClientSide/BugTests/InvalidURL_Spec.ts
  21. cypress/e2e/Regression/ClientSide/BugTests/JSParse_Spec.ts
  22. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug14002_Spec.ts
  23. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug15056_Spec.ts
  24. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug15909_Spec.ts
  25. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug19982_Spec.ts
  26. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug20841_Spec.ts
  27. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug24194_Spec.ts
  28. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug28764_Spec.ts
  29. cypress/e2e/Regression/ClientSide/BugTests/JS_Bug29131_spec.ts
  30. cypress/e2e/Regression/ClientSide/BugTests/Moment_Spec.ts
  31. cypress/e2e/Regression/ClientSide/BugTests/Widget_Bug27119_Spec.ts
  32. cypress/e2e/Regression/ClientSide/BugTests/invalidLintError_Spec.ts
  33. cypress/e2e/Regression/ClientSide/Debugger/JSObjects_navigation_spec.ts
  34. cypress/e2e/Regression/ClientSide/ExplorerTests/JSEditorContextMenu_Spec.ts
  35. cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js
  36. cypress/e2e/Regression/ClientSide/ExplorerTests/Renaming_spec.js
  37. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js
  38. cypress/e2e/Regression/ClientSide/Git/GitSync/GitBugs_spec.js
  39. cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js
  40. cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
  41. cypress/e2e/Regression/ClientSide/IDE/Canvas_View_mode.ts
  42. cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts
  43. cypress/e2e/Regression/ClientSide/JSObject/JSObjectMutation_spec.ts
  44. cypress/e2e/Regression/ClientSide/JSObject/JS_Editor_Assert_NoFunctionAvailableText_spec.ts
  45. cypress/e2e/Regression/ClientSide/Linting/AsyncFunctionsBoundInSyncFields_Spec.ts
  46. cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
  47. cypress/e2e/Regression/ClientSide/Linting/EntityPropertiesLint_spec.ts
  48. cypress/e2e/Regression/ClientSide/Linting/ErrorReporting_spec.ts
  49. cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts
  50. cypress/e2e/Regression/ClientSide/OtherUIFeatures/ErrorMessages_spec.ts
  51. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Logs2_spec.js
  52. cypress/e2e/Regression/ClientSide/PartialImportExport/PartialExport_Widgets_spec.ts
  53. cypress/e2e/Regression/ClientSide/PeekOverlay/PeekOverlay_Spec.ts
  54. cypress/e2e/Regression/ClientSide/PublishedApps/PublishedModeToastToggle_Spec.ts
  55. cypress/e2e/Regression/ClientSide/Refactoring/Refactoring_spec.ts
  56. cypress/e2e/Regression/ClientSide/SetProperty/SetOptions_Spec.ts
  57. cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts
  58. cypress/e2e/Regression/ClientSide/VisualTests/JSEditorComment_spec.js
  59. cypress/e2e/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js
  60. cypress/e2e/Regression/ClientSide/VisualTests/JSEditorSaveAndAutoIndent_spec.js
  61. cypress/e2e/Regression/ClientSide/Widgets/Button/Button2_spec.ts
  62. cypress/e2e/Regression/ClientSide/Widgets/ImperativeStoreUpdate_spec.ts
  63. cypress/e2e/Regression/ClientSide/Widgets/ListV2/ListV2_SerververSide_spec.js
  64. cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts
  65. cypress/e2e/Regression/ServerSide/ApiTests/API_TestExecuteWithDynamicBindingInUrl_spec.ts
  66. cypress/e2e/Regression/ServerSide/JsFunctionExecution/Fetch_Spec.ts
  67. cypress/e2e/Regression/ServerSide/JsFunctionExecution/PlatformFn_spec.ts
  68. cypress/e2e/Regression/ServerSide/JsFunctionExecution/SetTimeout_spec.ts
  69. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad2_Spec.ts
  70. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js
  71. cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts
  72. cypress/e2e/Regression/ServerSide/OnLoadTests/OnLoadActions_Spec.ts
  73. cypress/e2e/Regression/ServerSide/Params/PassingParams_Spec.ts
To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@riodeuno riodeuno self-assigned this May 10, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 10, 2024 •
edited

Walkthrough

The changes involve the removal of the minDynamicHeight property from the StatboxWidget to potentially address issues with its dynamic height behavior. Additionally, a new Cypress test file Statbox_spec.ts has been added to ensure proper functionality of the Statbox widget's dynamic height adjustments.

Changes

File Path Change Summary
.../cypress/e2e/Regression/ClientSide/.../Statbox_spec.ts New test file for dynamic height adjustment of Statbox widget.
.../src/widgets/StatboxWidget/widget/index.tsx Removed minDynamicHeight: 14 from StatboxWidget.

Possibly related issues

  • [Bug]: Statbox widget has inconsistent min heights #28677: The removal of minDynamicHeight could address inconsistencies in the Statbox widget's min-height behavior as described in the issue. This change may help in allowing the widget's height to decrease below previously set minimums, aligning with the issue's objectives.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@riodeuno riodeuno added Stat Box Widget Issues related to stat box ok-to-test Required label for CI labels May 10, 2024
coderabbitai[bot]
coderabbitai bot reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

app/client/cypress/e2e/Regression/ClientSide/DynamicHeight/Statbox_spec.ts
Comment on lines +23 to +52
// Function to delete widget and verify height change
function deleteWidgetAndVerifyHeightChange(widgetName: string) {
agHelper
.GetWidgetCSSHeight(
locators._widgetInDeployed(draggableWidgets.STATBOX),
)
.then(($currentStatboxHeight) => {
EditorNavigation.SelectEntityByName(
widgetName,
EntityType.Widget,
{},
["Statbox1"],
);
agHelper.PressDelete();
agHelper.WaitUntilAllToastsDisappear();
assertHelper.AssertNetworkStatus("updateLayout");
agHelper.Sleep(2000);

agHelper
.GetWidgetCSSHeight(
locators._widgetInDeployed(draggableWidgets.STATBOX),
)
.then(($updatedStatboxHeight) => {
// Verify that the height of the Statbox widget has decreased
expect($currentStatboxHeight).to.not.equal(
$updatedStatboxHeight,
);
});
});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing the hardcoded sleep with a more reliable wait condition to avoid flaky tests.

@riodeuno riodeuno added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 13, 2024
@LuisVicenteCorreia LuisVicenteCorreia mentioned this pull request May 20, 2024
Open
@github-actions GitHub Actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@riodeuno riodeuno

Labels
ok-to-test Required label for CI Stale Stat Box Widget Issues related to stat box
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@riodeuno