chore: Adding missing function in cypress git sync helper and syncing the common file across the two repositories. #33360
+887,258
−2,388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the common file across the two repositories.
WalkthroughWalkthroughThe recent changes across various icon components focus on improving code readability by restructuring the SVG content within multi-line JSX blocks. These updates aim to enhance maintainability without altering the underlying functionality of the components. Changes
Tip 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 CommunicationShould the DevRel and Marketing teams inform users about this change?
|
github-actions
bot
added
the
skip-changelog
pratapaprasanna
previously approved these changes
May 10, 2024
2 tasks
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Out of diff range and nitpick comments (3)
app/client/README.md (1)
4-4: Consider adding a preposition after the link to improve readability. For example, "This project was bootstrapped with Create React App. For more details on setting up your development machine, please refer to the Setup Guide."app/client/README.old.md (2)
15-17: Consider varying the sentence structure to enhance readability. For example, "Click the README.md link from the list of files to start editing it directly."
16-17: Add a comma before 'and' in the sentence: "The commit page will open, and you’ll see the change you just made."
| // could return either boolean or string based on value | ||
| const parseConfig = (config) => { | ||
| if ( | ||
| (config.startsWith("{") && config.startsWith("}")) || |
There was a problem hiding this comment.
Fix the logical error in the condition.
- if (config.startsWith("{") && config.startsWith("}")) ||
+ if (config.startsWith("{") || config.endsWith("}")) ||This change ensures that the function correctly identifies strings that start with "{" or end with "}".
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| (config.startsWith("{") && config.startsWith("}")) || | |
| (config.startsWith("{") || config.endsWith("}")) || |
| const CLOUD_HOSTING = parseConfig('{{env "APPSMITH_CLOUD_HOSTING"}}'); | ||
| const ZIPY_KEY = parseConfig('{{env "APPSMITH_ZIPY_SDK_KEY"}}'); | ||
| const AIRGAPPED = parseConfig('{{env "APPSMITH_AIRGAP_ENABLED"}}'); | ||
| </script> |
There was a problem hiding this comment.
Replace deprecated attachEvent with addEventListener for better compatibility with modern browsers.
- else if (w.attachEvent) {
- w.attachEvent("onload", l);
- } else {
+ else {
w.addEventListener("load", l, false);
}This change ensures that the event listener is compatible with all modern browsers.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| </script> | |
| </script> |
trishaanand
added a commit
that referenced
this pull request
May 13, 2024
… the common file across the two repositories. (#33368) Fixes GitSync spec in CE repo. Previous PR which got dirty due to prettier check : #33360 ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Git"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9034256269
Commit: 0a0e030
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?