Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redirection to previous page after login #560

Merged
merged 4 commits into from
May 22, 2024

Conversation

sdrejkarz
Copy link
Contributor

@sdrejkarz sdrejkarz commented May 17, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Add redirection to previous page after login

What is the current behavior?

Add support for returnUrl to the webapp

What is the new behavior?

The user is redirected based on the entered path.
Tech note: The relative path is required, as the absolute path generates too many re-renders and the user is redirected to the home page due to an empty searchParam after the first redirection based on searchParam.

@sdrejkarz sdrejkarz force-pushed the feat/redirect-to-prev-page-after-login branch from 02a610a to 3536627 Compare May 21, 2024 12:34
@sdrejkarz sdrejkarz marked this pull request as ready for review May 21, 2024 14:50
@sdrejkarz sdrejkarz requested a review from mkleszcz May 21, 2024 14:50
@sdrejkarz sdrejkarz changed the title feat: add redirection to prev page after login feat: add redirection to previous page after login May 21, 2024
@sdrejkarz sdrejkarz force-pushed the feat/redirect-to-prev-page-after-login branch from edac575 to 5aec7ae Compare May 22, 2024 11:15
@sdrejkarz sdrejkarz merged commit 423afdc into master May 22, 2024
55 of 56 checks passed
@sdrejkarz sdrejkarz deleted the feat/redirect-to-prev-page-after-login branch May 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants