-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor bugs #97
fix: minor bugs #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just needs a higher version bump
@@ -2,7 +2,7 @@ export enum CreditCard { | |||
AmericanExpress = 'amex', | |||
Argencard = 'argencard', | |||
Cabal = 'cabal', | |||
Consosud = 'censosud', | |||
Cencosud = 'cencosud', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change, we need a higher version bump
@@ -319,7 +319,7 @@ export class Account extends Service { | |||
* @throws {AppwriteException} | |||
* @returns {Promise} | |||
*/ | |||
async deleteMfaAuthenticator<Preferences extends Models.Preferences>(type: AuthenticatorType, otp: string): Promise<Models.User<Preferences>> { | |||
async deleteMfaAuthenticator(type: AuthenticatorType, otp: string): Promise<{}> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also breaking change
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)