Fix the CodeCov Pipeline #1165
Open
Fix the CodeCov Pipeline #1165
+20
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
force-pushed
the
fix/1164-fix-codecov-pipeline
branch
24 times, most recently
from
28578ea
to
be59569
Compare
reglim
force-pushed
the
fix/1164-fix-codecov-pipeline
branch
6 times, most recently
from
8ffce2e
to
676caa0
Compare
reglim
force-pushed
the
fix/1164-fix-codecov-pipeline
branch
10 times, most recently
from
94269a5
to
1c7a168
Compare
reglim
changed the title
reglim
force-pushed
the
fix/1164-fix-codecov-pipeline
branch
2 times, most recently
from
4fba69b
to
c7c5bdb
Compare
reglim
force-pushed
the
fix/1164-fix-codecov-pipeline
branch
2 times, most recently
from
9d26498
to
c49b588
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
- Coverage 74.81% 65.96% -8.85%
==========================================
Files 144 143 -1
Lines 16248 16188 -60
==========================================
- Hits 12156 10679 -1477
- Misses 3152 4756 +1604
+ Partials 940 753 -187 ☔ View full report in Codecov by Sentry. |
reglim
force-pushed
the
fix/1164-fix-codecov-pipeline
branch
4 times, most recently
from
5405e77
to
5a2046d
Compare
Update the ci to go version 20, fix go test coveroutput and add listener that terminates the api in testing mode.
neolynx
force-pushed
the
fix/1164-fix-codecov-pipeline
branch
from
5a2046d
to
c8ea704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code coverage has had some issues in the past, which are addressed by this change.
Fixes: #1164
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
I changed the
go testcommand to output to the GOCOVERDIR and upgraded the ci to go version1.20.I also had to fix some issues that the linter detected, mainly replacing unused parameters with
_.Why this change is important?
The coverage should be accurate and it's not bad to test on the latest go version either.
Checklist
AUTHORS