Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add arm builds #1286

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

github: add arm builds #1286

wants to merge 16 commits into from

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 21, 2024

Fixes #1199

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

  • replace goxc and use go directly for debian builds
  • debianize and use dpkg-buildpackage
  • read go version from go.mod
  • build FreeBSD, MacOS and Linux separately

TODO

  • cleanup debian package / service

@neolynx neolynx self-assigned this Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81%. Comparing base (8d09c20) to head (4d02050).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1286      +/-   ##
==========================================
+ Coverage   74.79%   74.81%   +0.02%     
==========================================
  Files         144      144              
  Lines       16256    16248       -8     
==========================================
- Hits        12158    12156       -2     
+ Misses       3156     3152       -4     
+ Partials      942      940       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx
Copy link
Member Author

neolynx commented Apr 21, 2024

goxc does not seem to build for arm64:

ls -l build/
total 168736
-rw-r--r-- 1 root root 17893770 Apr 21 17:19 aptly_1.5.0+113+g6619f929_amd64.deb
-rw-r--r-- 1 root root 16546322 Apr 21 17:19 aptly_1.5.0+113+g6619f929_armhf.deb
-rw-r--r-- 1 root root 18089983 Apr 21 17:19 aptly_1.5.0+113+g6619f929_darwin_amd64.zip
-rw-r--r-- 1 root root 17016974 Apr 21 17:19 aptly_1.5.0+113+g6619f929_freebsd_386.zip
-rw-r--r-- 1 root root 17883988 Apr 21 17:19 aptly_1.5.0+113+g6619f929_freebsd_amd64.zip
-rw-r--r-- 1 root root 17057506 Apr 21 17:19 aptly_1.5.0+113+g6619f929_i386.deb
-rw-r--r-- 1 root root 17049372 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_386.tar.gz
-rw-r--r-- 1 root root 17887161 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_amd64.tar.gz
-rw-r--r-- 1 root root 16539569 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_arm.tar.gz
-rw-r--r-- 1 root root 16802958 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_arm64.tar.gz

-> depends on #1287

@neolynx neolynx changed the title gituhub: add arm builder workflow github: add arm builds Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add arm64 deb builds to main repo
1 participant