Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[not for review] test landed apt fa speed after migration complete #13323

Closed
wants to merge 9 commits into from

Conversation

igor-aptos
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@igor-aptos igor-aptos added CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels May 17, 2024
Copy link

trunk-io bot commented May 17, 2024

⏱️ 7h 56m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 3h 9m 🟥🟥🟥
execution-performance / single-node-performance 1h 42m 🟥🟥🟥🟥🟥 (+1 more)
rust-images / rust-all 59m 🟩🟩🟩🟩
rust-move-tests 40m 🟥🟥🟥🟥
rust-lints 23m 🟥🟩🟩🟩
run-tests-main-branch 16m 🟩🟩🟩🟩
execution-performance / test-target-determinator 16m 🟩🟩🟩🟩🟩 (+1 more)
test-target-determinator 11m 🟩🟩🟩🟩
check-dynamic-deps 7m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 7m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 45s 🟩🟩🟩🟩
file_change_determinator 37s 🟩🟩🟩🟩
file_change_determinator 36s 🟩🟩🟩🟩
permission-check 18s 🟩🟩🟩🟩
permission-check 16s 🟩🟩🟩🟩
permission-check 15s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 15s 🟩🟩🟩🟩🟩 (+1 more)
determine-docker-build-metadata 9s 🟩🟩🟩🟩
permission-check 8s 🟩🟩🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-targeted-unit-tests 52m 19m +174%
execution-performance / single-node-performance 36m 22m +61%
rust-images / rust-all 19m 13m +44%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos force-pushed the igor/optimize_fa_apt branch 2 times, most recently from ae06727 to b2a904d Compare May 28, 2024 06:54
Base automatically changed from igor/optimize_fa_apt to main May 28, 2024 18:03
@igor-aptos igor-aptos closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-execution-performance-full-test Run execution performance test (full version) CICD:run-execution-performance-test Run execution performance test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants