Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix gas for comparison testing tool #13335

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

rahxephon89
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 18, 2024

⏱️ 4h 22m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 1h 30m 🟥🟥🟥🟩
rust-move-unit-coverage 1h 2m 🟩🟩🟩🟩
rust-move-tests 47m 🟩🟩🟩🟩
rust-lints 23m 🟩🟩🟩🟩
run-tests-main-branch 18m 🟩🟩🟩🟩
general-lints 7m 🟩🟩🟩🟩
file_change_determinator 6m 🟩🟩🟩🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 38s 🟩🟩🟩🟩
permission-check 34s 🟩🟩🟩🟩
permission-check 17s 🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 12m 8m +48%
rust-targeted-unit-tests 23m 18m +32%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.4%. Comparing base (6ca7c3f) to head (a18a5d3).

Files Patch % Lines
third_party/move/move-compiler-v2/src/options.rs 68.7% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13335       +/-   ##
===========================================
- Coverage    71.9%    58.4%    -13.6%     
===========================================
  Files        2314      821     -1493     
  Lines      455089   197419   -257670     
===========================================
- Hits       327642   115419   -212223     
+ Misses     127447    82000    -45447     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant