Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time it #13339

Closed
wants to merge 2 commits into from
Closed

time it #13339

wants to merge 2 commits into from

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented May 19, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 19, 2024

⏱️ 4h 11m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-smoke-tests 38m 🟩
forge-e2e-test / forge 28m 🟩🟩
rust-images / rust-all 26m 🟩🟩
rust-targeted-unit-tests 26m 🟥
execution-performance / single-node-performance 25m 🟩
forge-compat-test / forge 24m 🟩🟩
cli-e2e-tests / run-cli-tests 20m 🟥🟥
run-tests-main-branch 16m 🟩🟩🟩
rust-move-tests 14m 🟩
rust-lints 10m 🟩
rust-build-cached-packages 4m 🟩
check 4m 🟩
general-lints 4m 🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 4m 🟩🟩
check-dynamic-deps 3m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 46s 🟩🟩
file_change_determinator 41s 🟩🟩🟩🟩
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 18s 🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 10s 🟩🟩🟩🟩
execution-performance / file_change_determinator 8s 🟩
determine-docker-build-metadata 5s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 9m 6m +38%

settingsfeedbackdocs ⋅ learn more about trunk.io

@msmouse
Copy link
Contributor Author

msmouse commented May 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @msmouse and the rest of your teammates on Graphite Graphite

@msmouse msmouse added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label May 19, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> a518b20c3a893b20f394a70c88eeccb35e0da90a

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a518b20c3a893b20f394a70c88eeccb35e0da90a (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6391 txn/s, latency: 5024 ms, (p50: 4800 ms, p90: 9000 ms, p99: 10300 ms), latency samples: 236500
2. Upgrading first Validator to new version: a518b20c3a893b20f394a70c88eeccb35e0da90a
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1476 txn/s, latency: 16431 ms, (p50: 19500 ms, p90: 23800 ms, p99: 27900 ms), latency samples: 88560
3. Upgrading rest of first batch to new version: a518b20c3a893b20f394a70c88eeccb35e0da90a
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1875 txn/s, latency: 15525 ms, (p50: 19200 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 91880
4. upgrading second batch to new version: a518b20c3a893b20f394a70c88eeccb35e0da90a
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3279 txn/s, latency: 9771 ms, (p50: 10300 ms, p90: 12300 ms, p99: 12600 ms), latency samples: 127900
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a518b20c3a893b20f394a70c88eeccb35e0da90a passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a518b20c3a893b20f394a70c88eeccb35e0da90a

two traffics test: inner traffic : committed: 7696 txn/s, latency: 5093 ms, (p50: 4800 ms, p90: 6000 ms, p99: 10800 ms), latency samples: 3324940
two traffics test : committed: 100 txn/s, latency: 1914 ms, (p50: 1900 ms, p90: 2100 ms, p99: 2300 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.210, avg: 0.202", "QsPosToProposal: max: 0.299, avg: 0.246", "ConsensusProposalToOrdered: max: 0.453, avg: 0.426", "ConsensusOrderedToCommit: max: 0.420, avg: 0.405", "ConsensusProposalToCommit: max: 0.856, avg: 0.832"]
Max round gap was 1 [limit 4] at version 1708739. Max no progress secs was 4.87611 [limit 15] at version 1708739.
Test Ok

@msmouse msmouse closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant