Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#168: Refactor PostgreSQLHistoryContextController #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#168: Refactor PostgreSQLHistoryContextController #169

wants to merge 1 commit into from

Conversation

erzohrakhan
Copy link

@erzohrakhan erzohrakhan commented Jul 30, 2023 •
edited

closes #168

  • Use constructor injection instead of field injection for better testability and maintainability

  • Rename 'get' method to 'getById' for clarity

  • Rename 'put' method to 'update' for clarity

  • Add more descriptive method names

  • Changed @PostMapping annotation to @GetMapping and @PutMapping as per Rest principle

I have read the Arakoo CLA Document and I hereby sign the CLA
recheck

- Use constructor injection instead of field injection for better tes…
db16b8f 
…tability and maintainability

- Rename 'get' method to 'getById' for clarity
- Rename 'put' method to 'update' for clarity
- Add more descriptive method names
- Changed @PostMapping annotation to @GetMapping and @PutMapping as per Rest principle
@github-actions
Copy link

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the Arakoo Contributor License Agreement. You can sign the CLA by adding a new comment to this pull request and pasting exactly the following text.

I have read the Arakoo CLA Document and I hereby sign the CLA

Zohra Khan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@erzohrakhan
Copy link
Author

I have read the Arakoo CLA Document and I hereby sign the CLA
recheck

@erzohrakhan
Copy link
Author

I have read the Arakoo CLA Document and I hereby sign the CLA

@erzohrakhan
Copy link
Author

recheck

@sandys
Copy link
Contributor

sandys commented Jul 30, 2023

hi @erzohrakhan
thanks for your contribution! ur email address is mismatching with ur github id, so the cla check is failing, but dont worry we will review and merge it if the code passes

@sandys
Copy link
Contributor

sandys commented Jul 30, 2023

@erzohrakhan also would like to invite you to our discord. would love to have u over there - https://discord.gg/g6HTfQWh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor PostgreSQLHistoryContextController for better readability
2 participants
@erzohrakhan @sandys