New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorstore/lancedb #889
base: main
Are you sure you want to change the base?
Vectorstore/lancedb #889
Conversation
@akashAD98 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
+ Coverage 20.00% 20.19% +0.18%
==========================================
Files 72 73 +1
Lines 3264 3283 +19
==========================================
+ Hits 653 663 +10
- Misses 2611 2620 +9 ☔ View full report in Codecov by Sentry. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
any chance to merge it @ajaythapliyal @dartpain |
Thanks @akashAD98 for your contribution and the effort you've put into this PR. I've taken a look at the code, and I have a few points I think we should address before merging:
Overall, addressing these points will enhance the robustness and usability of the module. Looking forward to your updates! |
Thanks for reply & review |
My concern is how can we pass URI for example to make it work.
Check out the quickstart |
ALSO we can pass (uri="/tmp/lancedb")
can be done like this ? havnt tested but just approch @dartpain |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
added lancedb as vector store
Why was this change needed? (You can also link to an open issue here)
Lancedb is a serverless vector database for AI applications. Easily add long-term memory to your LLM apps