Add python==3.12
#615
Merged
Add python==3.12
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, too early |
|
maybe we can start testing this without |
|
|
Merged
alvarobartt
reviewed
May 28, 2024
| @@ -19,7 +19,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | |||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
Just a heads up on Python 3.8 EOL https://devguide.python.org/versions/ (in case we want to reduce the CI time already)
There was a problem hiding this comment.
I think we can keep it until it's deprecated, it gets executed in parallel so we're not going to gain CI time.
gabrielmbmb
force-pushed
the
add-python3.12
branch
2 times, most recently
from
238af3c
to
7b9ca4c
Compare
gabrielmbmb
force-pushed
the
add-python3.12
branch
from
7b9ca4c
to
8f1cc76
Compare
gabrielmbmb
force-pushed
the
add-python3.12
branch
from
ee6cc0e
to
ee71536
Compare
gabrielmbmb
force-pushed
the
add-python3.12
branch
from
ee71536
to
a8389c6
Compare
plaguss
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds compatibility for
python==3.12.Caveats
vllmis not yet compatible withpython==3.12becauserayis not yet compatible with3.12vllmneedsoutlines == 0.0.34, while our integration requires>= 0.0.40. I'll create a PR tovllmto relax theoutlinesdependency.