Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLX model support #124

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

MLX model support #124

wants to merge 6 commits into from

Conversation

ZachNagengast
Copy link
Contributor

@ZachNagengast ZachNagengast commented Apr 23, 2024 •
edited

Draft PR for the early stages of supporting MLX based whisper models directly in WhisperKit. (To be updated)

Initial TODOs:

  • Setup swift package structure
  • MLXFeatureExtractor using FeatureExtracting protocol
  • MLXAudioEncoder inference using AudioEncoding protocol
  • MLXTextDecoder inference using TextDecoding protocol or TextDecoder subclass (research needed)
  • Downloading MLX models (research needed to mix and match model downloads between CoreML and MLX)
  • Loading MLX models with a new model protocol
  • Pipeline allowing mixing CoreML and MLX models
  • Compiling whisperkit-cli optionally with/without MLX
  • Tests
  • More TBD

@ZachNagengast ZachNagengast marked this pull request as draft April 23, 2024 04:57
ZachNagengast and others added 5 commits April 22, 2024 21:57
@ZachNagengast
Merge branch 'main' into mlx-support
e8e99fb
@jkrukowski
Added MLX feature extractor implementation (#129)
211c834 
* Added MLX feature extractor implementation

* CI fix

* added better multiarray conversion

* CI fix

* CI fix

* fixed `asMLMultiArray` implementation, fixed CI

* update xcode, trigger pr when targeting not main branch

* check if vision os builds

* update watch os version

* conditional watchos compilation

* conditional package.swift

* conditional package.swift

* ci fix

* ci fix

* ci fix

* ci fix

* ci fix

* ci fix

* ci fix

* ci fix

* ci fix

* ci fix

* ci fix

* add other tests targest back

* package.swift cleanup

* general cleanup

* revert to xcode 15.2
@ZachNagengast
Merge branch 'main' into mlx-support
1bc914d
@ZachNagengast
Merge branch 'mlx-support' of https://github.com/argmaxinc/WhisperKit …
6b8aaf7 
…into mlx-support
@jkrukowski
Added MLX Audio Encoder (#139)
7cc004b 
* added mlx audio encoder

* fixed model protocols

* removed not needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZachNagengast @jkrukowski