-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metric): add ls-remote request fail metric(#17956) #18250
feat(metric): add ls-remote request fail metric(#17956) #18250
Conversation
d6f495b
to
21266e3
Compare
Added argocd_git_lsremote_fail_total metric. Increment this metric if a git ls-remote request fails. Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
21266e3
to
4631447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful error metric to expose
@csantanapr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your contribution |
Wonderful many thanks! |
Added argocd_git_lsremote_fail_total metric. Increment this metric if a git ls-remote request fails. Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Added argocd_git_lsremote_fail_total metric.
Increment this metric if a git ls-remote request fails.
Checklist:
Closes #17956