-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HUAWEI MateBook E Go(sc8280xp) #6540
Conversation
config/boards/matebook-e-go.conf
Outdated
chroot_sdcard "apt-mark hold alsa-ucm-conf" | ||
} | ||
|
||
function post_family_tweaks_bsp__thinkpad_gaokun_bsp_bluetooth_addr() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a thinkpad device so this thinkpad_gaokun
should be renamed.
config/boards/matebook-e-go.conf
Outdated
EOD | ||
} | ||
|
||
function post_family_tweaks_bsp__thinkpad_gaokun_bsp_always_start_pdmapper() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thinkpad naming.
config/boards/matebook-e-go.conf
Outdated
EOD | ||
} | ||
|
||
function post_family_tweaks_bsp__thinkpad_gaokun_bsp_touchscreen_udev_unbind_i2c_hid_hack() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thinkpad naming.
config/boards/matebook-e-go.conf
Outdated
## | ||
## Include certain firmware in the initrd | ||
## | ||
function post_family_tweaks_bsp__thinkpad_gaokun_bsp_firmware_in_initrd() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thinkpad naming.
config/boards/matebook-e-go.conf
Outdated
} | ||
|
||
## Modules, required to boot, add them to initrd; might need to be done in '.d/x13s-modules' instead | ||
function post_family_tweaks_bsp__thinkpad_gaokun_bsp_modules_in_initrd() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thinkpad naming.
Also it would be sane to keep the same kernel family and add changes with a kernel patch. |
@chenxuecong2 some additional context why we like to avoid going quick ways https://armbian.atlassian.net/browse/AR-1988 |
Description
Add huawei matebook e go support
How Has This Been Tested?
Tested on HUAWEI MateBook E Go
installed on sd card and device is booting fine
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules