Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board firefly-itx-3588j #6609

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Add board firefly-itx-3588j #6609

merged 1 commit into from
Jun 2, 2024

Conversation

SeeleVolleri
Copy link
Contributor

@SeeleVolleri SeeleVolleri commented May 15, 2024

Description

I have a Firefly-itx-3588j board

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Build
  • neofetch
    image

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate lots new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related - kernel, u-boot, patches labels May 15, 2024
Copy link
Contributor Author

@SeeleVolleri SeeleVolleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll be good enough, the DTBs are on another branch which I'll commit later

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label May 15, 2024
@chainsx
Copy link
Member

chainsx commented May 16, 2024

This PR depend on the following PR:
armbian/linux-rockchip#188

@SeeleVolleri
Copy link
Contributor Author

Hi, I wish to add this board's dts file at edge kernel, should I place a single patch at https://github.com/armbian/build/tree/main/patch/kernel/rockchip-rk3588-edge?
The patch is a commit from https://github.com/armbian/linux-rockchip/commit/e22606250f245c652c78be53879cb6979300a94d.
Are there any naming guideline for patch file? Thanks!

@amazingfate
Copy link
Contributor

Just place mainline dts at patch/kernel/rockchip-rk3588-edge/dt/.

@SeeleVolleri
Copy link
Contributor Author

Just place mainline dts at patch/kernel/rockchip-rk3588-edge/dt/.

Does that means the dts must be in mainline kernel git first, then it's able to place in the path you mentioned?
Also pinctrl and dts Makefile too?

@amazingfate
Copy link
Contributor

Just place mainline dts at patch/kernel/rockchip-rk3588-edge/dt/.

Does that means the dts must be in mainline kernel git first, then it's able to place in the path you mentioned? Also pinctrl and dts Makefile too?

Just dts file would work. That dir is for out-of-tree mainline devicetree. You can see files existing in that dir.

@SeeleVolleri
Copy link
Contributor Author

Thanks!

@github-actions github-actions bot added size/large PR with 250 lines or more and removed size/small PR with less then 50 lines labels May 21, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines and removed size/large PR with 250 lines or more labels May 27, 2024
@SeeleVolleri SeeleVolleri marked this pull request as ready for review May 27, 2024 01:43
@chainsx chainsx added Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress labels May 27, 2024
@igorpecovnik
Copy link
Member

@SeeleVolleri If you want to become a board maintainer, adjust data here.

Ref: Board Maintainers Procedures and Guidelines

@igorpecovnik igorpecovnik added the 08 Milestone: Third quarter release label Jun 2, 2024
@igorpecovnik igorpecovnik merged commit 44caaf0 into armbian:main Jun 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related - kernel, u-boot, patches Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

5 participants