Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example DAG for databricks delta support #1585

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dimberman
Copy link
Collaborator

Description

What is the current behavior?

The Astro SDK currently does not have an example for loading, transforming, and processing data using Databricks' delta tables.

What is the new behavior?

This PR adds an example to the Astro SDK for loading, transforming, and processing data using Databricks' delta tables. The example includes the following steps:

  • Loading data from a CSV file in an s3 bucket into a delta table using the load_file function.
  • Transforming the data using Databricks delta SQL SDK and astro's transforn function
  • Moving resulting data into a pandas dataframe using the aql.dataframe function.

Does this introduce a breaking change?

No, this is a new feature and does not affect existing functionality.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@dimberman dimberman changed the title Add example DAG for databricks Add example DAG for databricks delta support Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +5.98 🎉

Comparison is base (6ed6ed9) 91.69% compared to head (b1623a3) 97.67%.

❗ Current head b1623a3 differs from pull request most recent head cee0b28. Consider uploading reports for the commit cee0b28 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
+ Coverage   91.69%   97.67%   +5.98%     
==========================================
  Files          72       23      -49     
  Lines        4250      904    -3346     
  Branches      511        0     -511     
==========================================
- Hits         3897      883    -3014     
+ Misses        257       21     -236     
+ Partials       96        0      -96     
Flag Coverage Δ
PythonSDK ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 95 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaxil
Copy link
Collaborator

kaxil commented Jan 19, 2023

@dimberman Can you get this to the finish line please?

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this PR to be merged once the checks pass

@dimberman
Copy link
Collaborator Author

@tatiana @kaxil so this PR runs fine in my local set up but it fails in CI due to #1744. Should we wait until we've solved #1744 before merging this PR or merge now and then solve?

@tatiana
Copy link
Collaborator

tatiana commented Feb 24, 2023

@dimberman, it would be great if we could address CI issue #1744. before merging this..! How is that going?

@phanikumv
Copy link
Collaborator

waiting on #1744

@pankajkoti pankajkoti removed their request for review May 3, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants