add individual ingress configuration per service #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+125
to
+126
| enablePerHostIngress: false | ||
|
|
There was a problem hiding this comment.
I think this per-host ingress configuration should be the only way to do it. I don't think we should allow the old way of doing it. If we switch to this new method then we reduce the amount of code we have to maintain and test while still providing the same features, just in a different way that is compatible with more environments.
Is there some reason we should keep the old way as an option?
There was a problem hiding this comment.
Slack thread https://astronomer.slack.com/archives/C02J8JT58CC/p1715623166453439
We agreed to keep the old way in, behind a feature flag, and run it through a deprecation phase.
There was a problem hiding this comment.
We can default this to true @pgvishnuram
danielhoherd
approved these changes
May 13, 2024
pgvishnuram
added a commit
that referenced
this pull request
May 14, 2024
* add individual ingress per service * update templating * added feature flag * fix pre-commit * re-work test cases * rework ingress template * update test cases * fix pre-commit * update test cases * Generalize some tests, add some test cases. --------- Co-authored-by: Daniel Hoherd <daniel.hoherd@gmail.com>
rishkarajgi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR segreagates the common ingress rules to individual rules per service to avoid policy issues
Related Issues
Testing
Yet to update
Merging
NA