[MRG] Change import and usage according to pdfminer latest changes #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xamey
changed the title
xamey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Camelot's dependency pdfminer has recently published a new version (20200720).
A minor change about a class name induces that camelot can't work anymore and fail every time.
Below, a screenshot of the error that is available in the trace :
Source
As visible in this diff, from version 20200517 to version 20200720, the class
PDFTextExtractionNotAllowedhas been renamed toPDFTextExtractionNotAllowedError.Perhaps, as we can see here and here, camelot still uses the previous syntax.
Moreover, as camelot has defined it pdfminer dependency in its requirements.txt, it automatically updated to the latest pdfminer version.
Solution
To resolve this problem, we just have to change the class name used in camelot to the new one.