Variable bpm #391
Open
Variable bpm #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aubio has 120 bpm hardcoded in various places. I use it to detect beats in live music to have my lighting synced to the music, which can have a different bpm. Some real-world problems this is trying to address:
This PR adds an extra
-b/--bpmcommand line parameter to set the target bpm. I've been using this for quite some time now, at anything higher than 120 it's fine. I didn't go as low as 15, but 60 works well enough. At ~60 it does appear to sometimes miss a beat (maybe I missed a buffer length somewhere?) but it's still a lot better compared to the bpm being hardcoded at 120.I only fixed tests enough so that it compiles again.