Add Experimental Relationship Counter API #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
relationship-counter
branch
from
6d7b6fd
to
5e3e649
Compare
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
relationship-counter
branch
from
3bed801
to
c2a68e0
Compare
This supports registration, unregistration and counting, but does not yet use a service, which means *all* CountRelationships calls will invoke a `count(*)` on the underlying datastore, which could be slow Fixes authzed#1860
josephschorr
force-pushed
the
relationship-counter
branch
from
c2a68e0
to
0180264
Compare
ecordell
reviewed
May 22, 2024
internal/datastore/crdb/migrations/zz_migration.0006_add_relationship_counters_table.go
Show resolved
Hide resolved
internal/datastore/crdb/migrations/zz_migration.0006_add_relationship_counters_table.go
Show resolved
Hide resolved
| } | ||
|
|
||
| func (r *pgReader) LookupCounters(ctx context.Context) ([]datastore.RelationshipCounter, error) { | ||
| return r.lookupCounters(ctx, "") |
There was a problem hiding this comment.
how about a constant for the ""?
| } | ||
|
|
||
| snapshotReader := ds.SnapshotReader(headRev) | ||
| count, err := snapshotReader.CountRelationships(ctx, req.Name) |
There was a problem hiding this comment.
so we never store the count or read the stored count?
There was a problem hiding this comment.
Not currently; its designed so we can layer the counting service on top as the followup
github-actions
bot
added
area/CLI
…s and adding TODOs to the rest
josephschorr
force-pushed
the
relationship-counter
branch
from
35eaf1f
to
76d92f4
Compare
|
Updated |
ecordell
approved these changes
May 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1860