Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-828] Send Python logs to ak server logs #286

Merged
merged 7 commits into from
May 28, 2024
Merged

[ENG-828] Send Python logs to ak server logs #286

merged 7 commits into from
May 28, 2024

Conversation

tebeka
Copy link
Contributor

@tebeka tebeka commented May 12, 2024

No description provided.

@tebeka tebeka closed this May 12, 2024
@tebeka tebeka reopened this May 12, 2024
daabr
daabr reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@daabr daabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it make more sense to send Python logs to the session log instead of the server log?

@daabr daabr mentioned this pull request May 24, 2024
Merged
@tebeka
Copy link
Contributor Author

tebeka commented May 27, 2024

Doesn't it make more sense to send Python logs to the session log instead of the server log?

These are the logs from ak_runner.py, not the user logs.

efiShtain
efiShtain approved these changes May 28, 2024
View reviewed changes
runtimes/pythonrt/pythonrt.go Show resolved Hide resolved
@tebeka tebeka merged commit 2d97b59 into main May 28, 2024
9 checks passed
@tebeka tebeka deleted the miki/py-log branch May 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daabr daabr daabr left review comments

@efiShtain efiShtain efiShtain approved these changes

@itayd itayd Awaiting requested review from itayd

@ig-ra ig-ra Awaiting requested review from ig-ra

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tebeka @efiShtain @daabr