-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-875: upgrade integrations UI #305
Conversation
very cool! but do we need to do some extra build step? also @daabr |
we need to run npm run build every time we change the html file with new css from tailwind, |
I like it a lot!! The only comment I have is that this forces us to add NPM to AK's Make rules, CI, linting, and to our list of required build tools in the Readme (similar to our docs repo). We can't rely on people running it manually. But that's the price of having a modern web UI embedded in an API server, I guess? I have a few stylistic notes. They should be fixed, but not in this PR, and probably by Ronen:
|
|
I love it. |
dd8039f
to
ba914ce
Compare
@itayd |
fun stuff with tailwind to make integration ui a bit better
wdyt?