apply: return all effects #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daabr
approved these changes
May 20, 2024
| "go.autokitteh.dev/autokitteh/sdk/sdktypes" | ||
| ) | ||
|
|
||
| type EffectType string |
There was a problem hiding this comment.
I would have called it "action" or "result", but it's entirely not important
| @@ -16,6 +16,23 @@ func Transform[A, B any](as []A, f func(A) B) []B { | |||
| return bs | |||
| } | |||
|
|
|||
| func TransformFilter[A, B any](as []A, f func(A) *B) []B { | |||
There was a problem hiding this comment.
Self reminder, not affecting this PR: https://linear.app/autokitteh/issue/ENG-881/tlc-for-the-kittehs-package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this returns all effects made (subject id, type and a free message). this can be used by UI to understand which objects where touched and act on it.
one usage is for the UI to check for newly created connections and suggest to initialize them, as it is done in this PR in the cli.