-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for alternative IDs using Hashids #2564
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 783cb9e and detected 0 issues on this pull request. View more on Code Climate. |
This PR has been marked as stale because there was no activity for the past 15 days. |
What is the status on this one? |
@gabrielgiroe1 what is the status on this one? |
The real ID is leaking on attach request params, let's try to find out more spots like this one and fix them. |
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Paul Bob <69730720+Paul-Bob@users.noreply.github.com> Co-authored-by: Adrian Marin <adrian@adrianthedev.com>
git reset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is generally ok.
I have a couple of questions and one more critical change request.
Good job taking it this far!
Description
Fixes #2563
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.