-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: profile and cover photos #2722
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 200545d and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
I have one concern about the way to declare the cover/photo components. IMO it should not rely on existing fields, and pass the photo URL directly on the API like grid view cover.
Pros:
- Any image can be used even an external URL
- Custom path helpers can be used to get the image URL
- No need of field declaration if user don't want to have that fields.
self.cover_photo = -> do
{
# size: :sm,
source: main_app.url_for(record.cover_photo.url)
}
end
yup! makes sense! |
This PR has been marked as stale because there was no activity for the past 15 days. |
Description
Adds a cover and profile photo to the show view of the record.
Todo:
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.