Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move default_url_options to controller extension #2780

Merged
merged 6 commits into from
May 23, 2024
Merged

fix: move default_url_options to controller extension #2780

merged 6 commits into from
May 23, 2024

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented May 16, 2024 •
edited

Description

Fixes the initialization process for all controllers.

Blocked by rails/rails#51933 rails/rails#51910

Related PRs

Edit tasklist title
Beta Give feedback Tasklist Related PRs, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. https://github.com/avo-hq/avo-dynamic_filters/pull/38
    Options
  2. https://github.com/avo-hq/avo-pro/pull/71
    Options
  3. https://github.com/avo-hq/avo-dashboards/pull/39
    Options
  4. https://github.com/avo-hq/avo-menu/pull/21
    Options

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label May 16, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented May 16, 2024 •
edited

Code Climate has analyzed commit e65e948 and detected 0 issues on this pull request.

View more on Code Climate.

Paul-Bob
Paul-Bob approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a refactor suggestion (untested)

app/controllers/concerns/avo/initializes_avo.rb Outdated Show resolved Hide resolved
adrianthedev
adrianthedev commented May 23, 2024
View reviewed changes
app/components/avo/sidebar/link_component.rb
@@ -19,7 +19,7 @@ def initialize(label: nil, path: nil, active: :inclusive, target: nil, data: {},

def is_external?
# If the path contains the scheme, check if it includes the root path or not
return !path.include?(Avo.mount_path) if URI(path).scheme.present?
return !path.include?(helpers.mount_path) if URI(path).scheme.present?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit related.

@adrianthedev adrianthedev merged commit d1c94e3 into main May 23, 2024
20 checks passed
@adrianthedev adrianthedev deleted the fix/move-default_url_options-to-all-controllers branch May 23, 2024 17:37
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@adrianthedev adrianthedev mentioned this pull request Jun 10, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Bob Paul-Bob Paul-Bob approved these changes

@gabrielgiroe1 gabrielgiroe1 gabrielgiroe1 approved these changes

Assignees
No one assigned
Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianthedev @Paul-Bob @gabrielgiroe1