SMHP: slurm exporter to report gpu metrics #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
sean-smith
approved these changes
Mar 6, 2024
perifaws
requested changes
Mar 6, 2024
| @@ -10,7 +10,7 @@ if sudo systemctl is-active --quiet slurmctld; then | |||
| echo "Go is already installed." | |||
| fi | |||
| echo "This was identified as the controller node because Slurmctld is running. Begining SLURM Exporter Installation" | |||
| git clone -b 0.20 https://github.com/vpenso/prometheus-slurm-exporter.git | |||
| git clone -b development https://github.com/vpenso/prometheus-slurm-exporter.git | |||
There was a problem hiding this comment.
-gpus-acct throws error with v0.20, contrary to documentation (>=0.19). A few issues link this to Slurm version. The development branch works and I can pin to specific commit.
If development branch (pin or not) is not preferred, need to test if main branch works. Otherwise, it's either no -gpus-acct or pin to the head of development branch (latest commit was two years ago anyway).
There was a problem hiding this comment.
Can you raise an issue on https://github.com/vpenso/prometheus-slurm-exporter to get another release cut?
KeitaW
force-pushed
the
smhp-slurm-exporter-gpu
branch
2 times, most recently
from
e48c186
to
b4a4395
Compare
KeitaW
force-pushed
the
main
branch
3 times, most recently
from
44e448e
to
1209815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Prometheus Slurm exporter to report GPU metrics (total, allocated).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.